-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lambda continuous testing failure #20012
Conversation
9e40dc7
to
395655c
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 395655c
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/amazon-lambda/deployment
! Skipped: docs extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 6 more 📦 extensions/amazon-lambda/deployment✖
|
It seems like the fix was not enough as |
Damn |
This failure is a completely different failure mode to the way it is failing currently, and happened on the second run of the test. |
395655c
to
6f32eca
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 6f32eca
Failures⚙️ JVM Tests - JDK 11 #- Failing: integration-tests/container-image/maven-invoker-way
📦 integration-tests/container-image/maven-invoker-way✖ |
...da/common-runtime/src/main/java/io/quarkus/amazon/lambda/runtime/AbstractLambdaPollLoop.java
Show resolved
Hide resolved
...azon-lambda/event-server/src/main/java/io/quarkus/amazon/lambda/runtime/MockEventServer.java
Show resolved
Hide resolved
Ok, considering thisrace condition, maybe better off supplying the connection URL to the AmazonLambdaRecorder.startPollLoop method? |
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building 6f32eca
|
6f32eca
to
44eadb3
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 44eadb3
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: extensions/smallrye-reactive-messaging-kafka/deployment
! Skipped: docs integration-tests/kubernetes/quarkus-standard-way-kafka integration-tests/reactive-messaging-kafka and 1 more 📦 extensions/smallrye-reactive-messaging-kafka/deployment✖
⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/amazon-lambda/deployment
! Skipped: docs extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 6 more 📦 extensions/amazon-lambda/deployment✖
✖
|
@stuartwdouglas What can I do to help with this? Do you think this is internal to core continuous testing? Or a problem with this lambda implementation? I cannot make the lambda continuous testing tests fail on my laptop. |
I will keep looking into it, I have been a bit distracted by preparing some talks. This failure mode is different to the original one I was seeing, so some progress has been made. |
44eadb3
to
d1b622e
Compare
I have made some potential fixes, lets see what CI says. |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building d1b622e
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
⚙️ JVM Tests - JDK 11 Windows #- Failing: devtools/cli extensions/amazon-lambda/deployment
! Skipped: docs extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 6 more 📦 devtools/cli✖
✖
📦 extensions/amazon-lambda/deployment✖
|
@patriot1burke I think this last failure is actually a problem with the mock server:
It looks like an event is getting 'lost' so the HTTP request times out. |
d1b622e
to
e2b3e46
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building e2b3e46
Failures⚙️ Initial JDK 11 Build #- Failing: extensions/amazon-lambda-rest/rest-event-server
! Skipped: docs extensions/amazon-lambda-rest/deployment integration-tests/amazon-lambda-rest 📦 extensions/amazon-lambda-rest/rest-event-server✖ |
e2b3e46
to
b1942ed
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building b1942ed
Full information is available in the Build summary check run. Failures⚙️ Devtools Tests - JDK 11 #- Failing: integration-tests/devtools
📦 integration-tests/devtools✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
📦 integration-tests/devtools/target/quarkus-codestart-build-test/project-maven-java-5b74f01b-a826-470a-8678-be63013f094e✖
📦 integration-tests/devtools/target/quarkus-codestart-build-test/project-maven-kotlin-dc4f5b15-8929-4c3f-888a-4f78bca9277c✖
⚙️ Devtools Tests - JDK 11 Windows #- Failing: integration-tests/devtools
📦 integration-tests/devtools✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
📦 integration-tests/devtools/target/quarkus-codestart-build-test/project-maven-java-744cbe25-9b94-4c8f-bfa0-9da857406dac✖
📦 integration-tests/devtools/target/quarkus-codestart-build-test/project-maven-kotlin-62e61ef7-efed-4e90-ad81-91b2c40c8e66✖
⚙️ JVM Tests - JDK 11 #- Failing: integration-tests/spring-web
📦 integration-tests/spring-web✖
⚙️ JVM Tests - JDK 11 Windows #- Failing: integration-tests/spring-web
📦 integration-tests/spring-web✖
⚙️ JVM Tests - JDK 16 #- Failing: integration-tests/spring-web
📦 integration-tests/spring-web✖
⚙️ Native Tests - Spring #- Failing: integration-tests/spring-web
📦 integration-tests/spring-web✖
|
b1942ed
to
aed12f1
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building aed12f1
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
⚙️ JVM Tests - JDK 11 #- Failing: integration-tests/spring-web
📦 integration-tests/spring-web✖
⚙️ Native Tests - Misc4 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
⚙️ Native Tests - Spring #- Failing: integration-tests/spring-web
📦 integration-tests/spring-web✖
|
@patriot1burke last two runs have not had the lambda failure (only unrelated failures because the build is broken). I think this should be good to go once the build is fixed. |
aed12f1
to
a2cefe2
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building a2cefe2
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
⚙️ Native Tests - Misc4 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
|
If the tests start before the dev mode has initialized the system property would be seen by dev mode, and dev mode could open it's endpoint on 8081. This causes the tests to be run against the dev mode endpoint which breaks change tracking. Also fixes a few other minor things.
a2cefe2
to
363a042
Compare
Failing Jobs - Building 363a042
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 16 #- Failing: devtools/cli
📦 devtools/cli✖
|
If the tests start before the dev mode has initialized the system
property would be seen by dev mode, and dev mode could open it's
endpoint on 8081. This causes the tests to be run against the dev mode
endpoint which breaks change tracking.
Also fixes a few other minor things.